-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
periodically check for stale restic repo locks #1708
Conversation
Signed-off-by: Steve Kriss <krisss@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine.
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
I've confirmed that when there are no stale locks, this is a no-op, and when there is a stale lock, this successfully clears it out. I also tweaked the |
One other note - restic considers locks "stale" if they've been around for >30min, even though in the normal case, they get refreshed every 5min. We might want to consider a PR to restic to make this "stale threshold" a CLI flag, so that we could say |
Hold on merging this, checking one thing. |
OK, looks fine, I just had some versioning issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Steve Kriss krisss@vmware.com
Fixes #1511
I think this is all we need to do, but I'm still working on testing it.